-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to typescript, undici, and improve contributing #42
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR!
I have left a few comments.
@puzpuzpuz @glasstiger a cool review here would be super nice:) sorry for pinging just want to move this forward |
Wow, that's a biggish PR! We may need some time to review it, so please keep this in mind. |
Yes, no hurry from my side, we forked internally and using it already in production, just wanted to ping to make sure that you're "subscribed" to this repo :) |
Hi guys, hope this pull-request suits you well
I've had a boring weekend and had time to give some love to this library, QuestDb is cool but db clients experience must be a requirement for you as a company, so since it's open-source I'm happy to collaborate with you 🤟
What's new?
CONTRIBUTING.md
guide for making it easier to collaborate and introduce new features.Breaking changes
Undici
which is by far better, easier to handle retry, faster, and more maintained and its core contributors are Node maintainers.Performance improvements
Getting rid of http.agent and using Undici made that when I've installed the library in my project and run some benchmarks creating 2M rows in 64 iterations with a time limit of 5000ms of run we had a nice result:
Latency (average):
v4.0.0
achieves a ~14% reduction in average latency, indicating faster performance.Latency (median):
v4.0.0
shows a significant improvement in median latency, reducing it by ~28%.Throughput (average):
v4.0.0
.Throughput (median):
v4.0.0
delivers a ~35% improvement in median throughput.Summary of Improvements
v4.0.0
demonstrates superior performance and efficiency compared tov3.0.0
.These results confirm the improvements introduced in
v4.0.0
, making it a faster and more capable version.