Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPE when Kafka Connect requests a commit right after an error #23

Merged
merged 1 commit into from
May 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions connector/src/main/java/io/questdb/kafka/QuestDBSinkTask.java
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,18 @@ private boolean tryWriteLogicalType(String name, Schema schema, Object value) {
return false;
}

@Override
public Map<TopicPartition, OffsetAndMetadata> preCommit(Map<TopicPartition, OffsetAndMetadata> currentOffsets) {
if (sender != null) {
flush(currentOffsets);
return currentOffsets;
} else {
// null sender indicates there was an error and we cannot guarantee that the data was actually sent
// returning empty map will cause the task to avoid committing offsets to Kafka
return Collections.emptyMap();
}
}

@Override
public void flush(Map<TopicPartition, OffsetAndMetadata> map) {
if (httpTransport) {
Expand Down
Loading