integration tests verification

questdb · Oct 12, 2023 · 72dc752 · 72dc752
1 parent 5a096b4
commit 72dc752
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/connector/src/main/java/io/questdb/kafka/QuestDBSinkTask.java b/connector/src/main/java/io/questdb/kafka/QuestDBSinkTask.java
@@ -132,8 +132,8 @@ public void put(Collection<SinkRecord> collection) {
             if (++batchesSinceLastError == 10) {
                 // why 10? why not to reset the retry counter immediately upon a successful flush()?
                 // there are two reasons for server disconnections:
-                // 1. the server is down / unreachable / other_infrastructure_issues
-                // 2. the client is sending bad data (e.g. pushing a string to a double column)
+                // 1. infrastructure: the server is down / unreachable / other_infrastructure_issues
+                // 2. structural: the client is sending bad data (e.g. pushing a string to a double column)
                 // errors in the latter case are not recoverable. upon receiving bad data the server will *eventually* close the connection,
                 // after a while, the client will notice that the connection is closed and will try to reconnect
                 // if we reset the retry counter immediately upon first successful flush() then we end-up in a loop where we flush bad data,
@@ -434,7 +434,7 @@ private boolean tryWriteLogicalType(String name, Schema schema, Object value) {
 
     @Override
     public void flush(Map<TopicPartition, OffsetAndMetadata> map) {
-        // not needed as put() flushes after each record
+        // not needed as put() flushes after each batch
     }
 
     @Override

diff --git a/integration-tests/pom.xml b/integration-tests/pom.xml
@@ -27,6 +27,7 @@
                     <execution>
                         <goals>
                             <goal>integration-test</goal>
+                            <goal>verify</goal>
                         </goals>
                     </execution>
                 </executions>