Disable sample by and latest on with no ts

questdb · Jun 24, 2024 · 52c583c · 52c583c
1 parent 3313702
commit 52c583c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/components/queryBuilder/GroupBy.tsx b/src/components/queryBuilder/GroupBy.tsx
@@ -10,6 +10,7 @@ interface GroupByEditorProps {
   groupBy: string[];
   onGroupByChange: (groupBy: string[]) => void;
   labelAndTooltip: typeof selectors.components.QueryEditor.QueryBuilder.GROUP_BY;
+  isDisabled: boolean;
 }
 export const GroupByEditor = (props: GroupByEditorProps) => {
   const columns: SelectableValue[] = (props.fieldsList || []).map((f) => ({ label: f.label, value: f.name }));
@@ -34,7 +35,7 @@ export const GroupByEditor = (props: GroupByEditorProps) => {
     <EditorField tooltip={tooltip} label={label}>
       <MultiSelect
         options={columns}
-        placeholder="Choose"
+        placeholder={props.isDisabled ? 'Table is missing designated timestamp' : 'Choose'}
         isOpen={isOpen}
         onOpenMenu={() => setIsOpen(true)}
         onCloseMenu={() => setIsOpen(false)}
@@ -43,6 +44,7 @@ export const GroupByEditor = (props: GroupByEditorProps) => {
         value={groupBy}
         allowCustomValue={true}
         width={50}
+        disabled={props.isDisabled}
       />
     </EditorField>
   );

diff --git a/src/components/queryBuilder/QueryBuilder.tsx b/src/components/queryBuilder/QueryBuilder.tsx
@@ -230,6 +230,7 @@ export const QueryBuilder = (props: QueryBuilderProps) => {
             onGroupByChange={onGroupByChange}
             fieldsList={fieldsList}
             labelAndTooltip={selectors.components.QueryEditor.QueryBuilder.SAMPLE_BY}
+            isDisabled={builder.timeField.length === 0}
           />
         </EditorRow>
       )}
@@ -264,7 +265,11 @@ export const QueryBuilder = (props: QueryBuilderProps) => {
 
       {builder.mode === BuilderMode.Trend && (
         <EditorRow>
-          <SampleByFillEditor fills={builder.sampleByFill || []} onFillsChange={onFillChange} />
+          <SampleByFillEditor
+            fills={builder.sampleByFill || []}
+            onFillsChange={onFillChange}
+            isDisabled={builder.timeField.length === 0}
+          />
         </EditorRow>
       )}
 
@@ -275,6 +280,7 @@ export const QueryBuilder = (props: QueryBuilderProps) => {
             onGroupByChange={onGroupByChange}
             fieldsList={fieldsList}
             labelAndTooltip={selectors.components.QueryEditor.QueryBuilder.GROUP_BY}
+            isDisabled={builder.timeField.length === 0}
           />
         </EditorRow>
       )}

diff --git a/src/components/queryBuilder/SampleByFillEditor.tsx b/src/components/queryBuilder/SampleByFillEditor.tsx
@@ -9,6 +9,7 @@ import { GroupBase, OptionsOrGroups } from 'react-select';
 interface FillEditorProps {
   fills: string[];
   onFillsChange: (fills: string[]) => void;
+  isDisabled: boolean;
 }
 
 const fillModes: SelectableValue[] = [];
@@ -85,6 +86,8 @@ export const SampleByFillEditor = (props: FillEditorProps) => {
         width={50}
         isClearable={true}
         hideSelectedOptions={true}
+        placeholder={props.isDisabled ? 'Table is missing designated timestamp' : 'Choose'}
+        disabled={props.isDisabled}
       />
     </EditorField>
   );