Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs for DECLARE syntax #86

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

docs for DECLARE syntax #86

wants to merge 28 commits into from

Conversation

nwoolmer
Copy link
Contributor

@nwoolmer nwoolmer commented Nov 28, 2024 •
edited
Loading

Docs for questdb/questdb#5207

Also contains missing updates for ATOMIC (CREATE, INSERT) and FROM-TO for SAMPLE BY.

@nwoolmer nwoolmer added the documentation Improvements or additions to documentation label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

🚀 Build success!

Latest successful preview: https://preview-86--questdb-documentation.netlify.app

Commit SHA: 0a3628e

📦 Build generates a preview & updates link on each commit.

@nwoolmer nwoolmer mentioned this pull request Nov 29, 2024
Merged
8 tasks
javier
javier reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add trailing semicolons to all sample queries, so when it opens on a web console (or if I copy and paste) I can execute directly even if I have other queries already there

nwoolmer
nwoolmer commented Jan 9, 2025
View reviewed changes
Copy link
Contributor Author

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javier reports!

documentation/reference/sql/declare.md Show resolved Hide resolved
documentation/reference/sql/declare.md Outdated Show resolved Hide resolved
documentation/reference/sql/declare.md Outdated Show resolved Hide resolved
@goodroot goodroot marked this pull request as ready for review January 10, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier javier javier left review comments

@goodroot goodroot goodroot approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwoolmer @javier @goodroot