Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add resume WAL troubleshooting #42

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

puzpuzpuz
Copy link
Contributor

No description provided.

@puzpuzpuz puzpuzpuz added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 14, 2024
@puzpuzpuz puzpuzpuz self-assigned this Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

🚀 Build success!

Latest successful preview: https://66bdd7fdb046f1a791dd15db--unruffled-blackwell-31bfb2.netlify.app

Commit SHA: c489b81

📦 Build generates a preview & updates link on each commit.

Copy link
Contributor

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Thanks

reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
| ---- |
| 1242 |

Since the maximum number of the problematic transactions is `1242`, you can now run resume operation for the `1243` transaction:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be the case more than one consecutive transaction is wrong and you need to repeat the process until getting to the right point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe add that the data at that particular transaction will be lost, but if you are using DEDUP and you have access to the original events (for example they are on Kafka, or other replayable source) it is safe to reingest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the process may have to be repeated. Added a trailing paragraph on that in bc9fbf0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a hint box with some words on dedup in e72fc14

ideoma
ideoma previously approved these changes Aug 15, 2024
Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and spelling fix, need to double check that the FAQ link works

reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
reference/sql/alter-table-resume-wal.md Outdated Show resolved Hide resolved
troubleshooting/faq.md Outdated Show resolved Hide resolved
troubleshooting/faq.md Outdated Show resolved Hide resolved
@puzpuzpuz
Copy link
Contributor Author

@nwoolmer addressed all comments in c489b81. PTAL

Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nwoolmer nwoolmer merged commit 92fbc15 into main Aug 15, 2024
2 checks passed
@nwoolmer nwoolmer deleted the puzpuzpuz_improve_resume_wal_docs branch August 15, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants