Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reference for Date to Timestamp conversion #36

Merged
merged 30 commits into from
Aug 8, 2024
Merged

Adding reference for Date to Timestamp conversion #36

merged 30 commits into from
Aug 8, 2024

Conversation

javier
Copy link
Contributor

@javier javier commented Aug 7, 2024 •
edited
Loading

Added new page /docs/clients/date-to-timestamp-conversion and an intro in /docs/reference/function/date-time/#timestamp-to-date-conversion.

This should improve developer experience and should help position the page better in search engines

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

🚀 Build success!

Latest successful preview: https://66b4ece62ca2643330bcffbd--unruffled-blackwell-31bfb2.netlify.app

Commit SHA: f73ccac

📦 Build generates a preview & updates link on each commit.

nwoolmer
nwoolmer reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool concept!

Here's a few suggestions to start, I can take a look at the rest tomorrow

clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
@nwoolmer nwoolmer added the documentation Improvements or additions to documentation label Aug 7, 2024
nwoolmer
nwoolmer reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits and snags, otherwise it looks good to go :)

clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Show resolved Hide resolved
clients/date-to-timestamp-conversion.md Outdated Show resolved Hide resolved
reference/function/date-time.md Outdated Show resolved Hide resolved
reference/function/date-time.md Outdated Show resolved Hide resolved
reference/function/date-time.md Outdated Show resolved Hide resolved
reference/function/date-time.md Outdated Show resolved Hide resolved
reference/function/date-time.md Outdated Show resolved Hide resolved
javier and others added 25 commits August 8, 2024 17:26
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
4fb1f42 
Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
5a1486d 
Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
0e67cce 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
6d8c1df 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
0dec4ea 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
691b165 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
3363219 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
01d022c 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
0aebdf6 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
26a1d45 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
b69e068 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
e88dcd3 
typo

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
2fb8a81 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
e599097 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
34a8d65 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
91b7410 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
75e1db4 
Style fixes

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
2a207ae 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
f0baa77 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
0d0516a 
typo

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
8d62456 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
6094660 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
dd0f090 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
826e0e4 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update clients/date-to-timestamp-conversion.md
2b05f9b 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
javier and others added 4 commits August 8, 2024 17:53
@javier @nwoolmer
Update reference/function/date-time.md
3eba910 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
d236111 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
f523668 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
@javier @nwoolmer
Update reference/function/date-time.md
f73ccac 
Style fix

Co-authored-by: Nick Woolmer <[email protected]>
nwoolmer
nwoolmer approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nwoolmer nwoolmer merged commit 2851d3c into main Aug 8, 2024
2 checks passed
@nwoolmer nwoolmer deleted the jv/timestamp_to_date_seo branch August 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwoolmer nwoolmer nwoolmer approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javier @nwoolmer