-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for SAMPLE BY FROM-TO #27
Conversation
🚀 Build success! Latest successful preview: https://66a279b3bc7eee6592887195--unruffled-blackwell-31bfb2.netlify.app Commit SHA: 9b87925
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid! We'll have to think through Railroad... 🚂 ...
Comments include examples of passive voice with alternatives.
It's tricky and seems pedantic. But it leads to better doc writing.
As always, take what you like.
reference/sql/sample-by.md
Outdated
@@ -18,6 +18,8 @@ use of the [FILL](#fill-options) keyword to specify a fill behavior. | |||
|
|||
### SAMPLE BY keywords | |||
|
|||
todo: railroad update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be blocked here. A fix will take some thinking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can remove this comment and merge without changing the railroad?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nwoolmer Agreed.
get this puppy out there!
WIP Docs for questdb/questdb#4733