Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for SAMPLE BY FROM-TO #27

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Changes for SAMPLE BY FROM-TO #27

merged 9 commits into from
Jul 25, 2024

Conversation

nwoolmer
Copy link
Contributor

@nwoolmer nwoolmer commented Jul 24, 2024

WIP Docs for questdb/questdb#4733

@nwoolmer nwoolmer added the documentation Improvements or additions to documentation label Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

🚀 Build success!

Latest successful preview: https://66a279b3bc7eee6592887195--unruffled-blackwell-31bfb2.netlify.app

Commit SHA: 9b87925

📦 Build generates a preview & updates link on each commit.

Copy link
Collaborator

@goodroot goodroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! We'll have to think through Railroad... 🚂 ...

Comments include examples of passive voice with alternatives.

It's tricky and seems pedantic. But it leads to better doc writing.

As always, take what you like.

reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
reference/sql/sample-by.md Outdated Show resolved Hide resolved
@@ -18,6 +18,8 @@ use of the [FILL](#fill-options) keyword to specify a fill behavior.

### SAMPLE BY keywords

todo: railroad update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be blocked here. A fix will take some thinking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove this comment and merge without changing the railroad?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwoolmer Agreed.

@goodroot goodroot marked this pull request as ready for review July 25, 2024 15:29
@goodroot goodroot enabled auto-merge (squash) July 25, 2024 16:09
@goodroot goodroot merged commit b1f9d19 into main Jul 25, 2024
2 checks passed
@goodroot goodroot deleted the nw_sample_by_from_to branch July 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants