Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot/backup docs improvement #26

Merged
merged 14 commits into from
Jul 25, 2024
Merged

snapshot/backup docs improvement #26

merged 14 commits into from
Jul 25, 2024

Conversation

jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Jul 23, 2024

TODO:

Copy link

github-actions bot commented Jul 23, 2024

🚀 Build success!

Latest successful preview: https://66a277822ad02d51edcdaeb6--unruffled-blackwell-31bfb2.netlify.app

Commit SHA: e5230ff

📦 Build generates a preview & updates link on each commit.

@jerrinot jerrinot marked this pull request as ready for review July 25, 2024 09:07
@jerrinot
Copy link
Contributor Author

@goodroot it's ready for your pass. feel free to edit it as you see fit. the reference documentation could be more ... reference-like and the guide could use more imperative language. but I think this is still an improvement compared to the current state.

operations/backup.md Outdated Show resolved Hide resolved
goodroot
goodroot previously approved these changes Jul 25, 2024
@goodroot goodroot enabled auto-merge (squash) July 25, 2024 15:58
@goodroot goodroot merged commit 245f05e into main Jul 25, 2024
2 checks passed
@goodroot goodroot deleted the jh_backup_revamp branch July 25, 2024 16:04
@goodroot
Copy link
Collaborator

goodroot commented Jul 25, 2024

Much appreciated, this is a large improvement.

Made a somewhat bold decision to deprecate the backup doc & redir to snapshot.

The main reason is to clear up the search/discovery issue.

questdb/questdb#4811

Use the deprecated BACKUP operation. Not only it's deprecated, it does not support incremental backups either.

Updated this line to point to a gist vs. the documentation.

However, is it also the case that BACKUP has been deprecated since 7.3.3?

Or is it still available today in 8.1.0?

@jerrinot
Copy link
Contributor Author

@goodroot: thanks improving this PR!

About the BACKUP situation: Between 7.3.3(?) it was deprecated on all platforms, but Windows. From 8.1 upwards it's deprecated on all platforms, including Windows. Yet the command itself is still there and works.

@goodroot
Copy link
Collaborator

@jerrinot Got it - thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants