Add note on compression choices for ZFS #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Build success! Latest successful preview: https://668ff2592873170497e65b36--unruffled-blackwell-31bfb2.netlify.app Commit SHA: 7b6b6c2
|
puzpuzpuz
reviewed
Jul 11, 2024
Thanks Andrei! Co-authored-by: Andrei Pechkurov <[email protected]>
puzpuzpuz
previously approved these changes
Jul 11, 2024
goodroot
reviewed
Jul 11, 2024
goodroot
approved these changes
Jul 11, 2024
|
Thank you! Made one minor addition to header to put compression choices in the header. For search, the file name and header are indexed. So, added the choices to the header so they can be discovered when searched. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some feedback on lz4 vs zstd, here's some basic info on the choices.