Vec: removed Clone trait and introduced TryClone trait #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunra
changed the title
|
A fair question is if to allow Elements that are cloneable may or may not allocate. There's nothing in the type system that can help us distinguish between the two cases. @nikomatsakis's |
eugenels
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change drops support for the
Clonetrait, since that would have internally allocated and failed. It introduces a newTryClonein its place.This issue was spotted here: https://www.reddit.com/r/rust/comments/1fy7cu8/comment/lqvd9me/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
This PR does not provide complete support for the
TryClonetrait. Some outstanding work is detailed here: #7