Add in Osm and mOsm/kg for measurement done with Osmometer

[Toby-Broom]

I added back the Osm units for review

[steveraysteveray]

In the description of the OsmoticConcentration, I'm a little uncomfortable with using the word "quantity" as it might cause confusion related to qudt:Quantity. Would you consider some alternative natural language word, or just use QuantityKind?

Secondly, we need to define unit:OSM if we are to define MilliOSM-PER-KiloGM.

[steveraysteveray]

Oh, and also, don't forget to update CHANGELOG.md!

[Toby-Broom]

In the description of the OsmoticConcentration, I'm a little uncomfortable with using the word "quantity" as it might cause confusion related to qudt:Quantity. Would you consider some alternative natural language word, or just use QuantityKind?

Secondly, we need to define unit:OSM if we are to define MilliOSM-PER-KiloGM.

The other osmotic ones use this sort of description so should probably refactor these as well?

[steveraysteveray]

The quantitykind:OsmoticConcentration description and dimension vector tell me it is moles per volume. But the unit:MilliOSM-PER-KiloGM shows a dimension of moles per (volume x mass), so it cannot have qudt:hasQuantityKind of OsmoticConcentration since they are of different dimensionalities. Could you adjust and create additional quantity kinds if needed?

[Toby-Broom]

I think I made a mistake, I did osmotic concentration over mass but it should be osmol/mass so it's then the same as qk: AmountOfSubstancePerMass. I defined the unit osmole which is same as mole but specific to the osmotically active entity. I think normally people would use the osm/L variant like like mol/L but in this case they are using the mass based version.

[steveraysteveray]

Two changes requested. See embedded comments.

[steveraysteveray]

So sorry for dragging this out. Juggling multiple changes. Your latest fixes look great. There's now the merge conflict because of the maven update we just made. Would you mind resyncing your branch with our main, and resolving the conflict in changelog.md? Just need to add your lines as well as to the other new lines in changelog.md.

Again, sorry for the delay.

[Toby-Broom]

No worries, mostly me :) Also, we make our own custom individuals so we can solve them in the short term but I like to push things upto you so everyone else can benift from the standardisation you bring

[fkleedorfer]

Some SHACL checks failed, please look at the output of the CI Build. In that log file there are some errors reported for the newly added entities. E.g., the conversionMultiplier must be 0.0, not 0. Please let us know if you need further assistance. Some of the messages there do not pertain to the triples that were added. Most likely they are only warnings.

[steveraysteveray]

@fkleedorfer, since some of the errors derive from the datatypes graph, can we exclude that graph from the validation temporarily until @ralphtq has had a chance to make those fixes?

[steveraysteveray]

@Toby-Broom, I found a subtle error in your submission for unit:OSM. The dimension vector contains "TD0" where it should contain "T0D0", and thus does not find it.

[steveraysteveray]

Same for unit:MilliOSM-PER-KiloGM

[fkleedorfer]

@steveraysteveray removing the datatypes graph from validation does not make the validation results (severity: info) go away - the entities that cause them are also in the schemas, apparently, which, I believe, we do need. The only problem with the validation results is that their severities are not printed in the maven output. When I find the time to update the shacl-maven-plugin, we can do something about that - but there isn't really anything we can do in our project right now.