Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding render option to the actions "render" and "publish" and cleaning code #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-fehr
Copy link

@m-fehr m-fehr commented Jun 27, 2024

This pull request addresses the feature in #102

What I did:

  • Introduced an optional profile input argument for specifying the profile to give to the render command.

  • To simplify the conditional logic the command strings are now dynamically build.

  • Moved the Git configuration to a separate step for clarity.

@cderv
Copy link
Collaborator

cderv commented Jun 27, 2024

Thanks.

Do you find an explicit profile option to the action easier than using QUARTO_PROFILE env var ?

      - name: Deploy gh-pages Preview
        uses: quarto-dev/quarto-actions/publish@v2
        with:
          target: gh-pages
        env:
          QUARTO_PROFILE: preview

Asking because adding --profile support is adding more cased to handle in the action yaml while it works already using env var.
So I am wondering if as user it seemed easier to have the profile configuration instead of env var.

@m-fehr
Copy link
Author

m-fehr commented Jun 28, 2024

I believe it is more intuitive considering that "--to" is also an explicit profile option.

When I reviewed the README for the render action, I naturally assumed there would be a corresponding render option. However, you could leave it as it is now, but it should be added to the README file.

cderv added a commit that referenced this pull request Jul 2, 2024
@cderv
Copy link
Collaborator

cderv commented Jul 2, 2024

I have added mention of QUARTO_PROFILE to READMEs

@cscheid are you in favor of adding a new

with:
  profile: preview

option in the action instead of just setting

env:
  QUARTO_PROFILE: preview

Just to get another view on this. Thanks !

@cscheid
Copy link
Contributor

cscheid commented Jul 2, 2024

I don't have a strong opinion either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants