Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IIR coefficient python script #964

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix IIR coefficient python script #964

merged 1 commit into from
Nov 11, 2024

Conversation

schmidf
Copy link

@schmidf schmidf commented Nov 11, 2024

Fixes #854. I checked the correctness of the coefficients using a Stabilizer with up-to-date firmware and a network analyzer.

Fix IIR coefficient python script
08181b7 
The Stabilizer firmware expects "a" coefficients with negative signs.
Also fixed a typo in the highpass b0 coefficient.
jordens
jordens approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as a temp fix, still pending the rewrite mentioned in the issue.

Proof by example (i.e. network analyzer) ultimately doesn't cut it but this is certainly an improvement.

@jordens
Copy link
Member

jordens commented Nov 11, 2024

Thanks!

@jordens jordens added this pull request to the merge queue Nov 11, 2024
Merged via the queue into quartiq:main with commit aa99010 Nov 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordens jordens jordens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IIR filter coefficients set incorrectly
2 participants
@schmidf @jordens