Fix/localized about sync issue #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make localized sites parser happy and not complain about bad xml attributes
|
🙈 The PR is closed and the preview is expired. |
cescoffier
requested changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in
_includes/about.htmlshould address another sync issue with the localized sites:https://github.com/quarkusio/es.quarkus.io/actions/runs/11649689659/job/32467265667
(at least, I think that it should... can't see any possible problems with other attributes)
(link to the iframe attributes: https://www.w3schools.com/tags/tag_iframe.ASP)
I also reverted the change in the output ... it was my wrong assumption that the sync action added a template file, while actually it was added here: https://github.com/quarkusio/quarkusio.github.io/pull/2041/files ... git history tree display was messed up when I was looking at it 😖 and looking at the path... it's to the data directory, not to the template 😖 sorry for that 😔