Rewrite OpenTelemetry properties to OTel prefix #48
Conversation
| - org.openrewrite.properties.ChangePropertyKey: | ||
| oldPropertyKey: quarkus.opentelemetry.tracer.sampler.ratio | ||
| newPropertyKey: quarkus.otel.traces.sampler.arg |
There was a problem hiding this comment.
@brunobat this one looks odd to me. Is it a 1-1 mapping?
I based my work on https://github.com/quarkusio/quarkus/pull/32050/files#diff-ce0b5beb6a1b039064cc19f31a98739c58721ab1c51f90f4fbfe3568c7eb7f5cR17-R28 .
There was a problem hiding this comment.
Those properties showed up previously. The full explanation is here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#extension-re-write
The sampler properties were re-writen and they don't map 1-1 with the older ones.
There was a problem hiding this comment.
If they don't map 1-1 and we can't rewrite them, we shouldn't include them. It's only this one that I should remove or there are others that won't work properly if they are rewritten?
There was a problem hiding this comment.
Only the sample related ones... The others should be fine.
There was a problem hiding this comment.
I think you are missing properties:
"quarkus.otel.propagators", "quarkus.opentelemetry.propagators"
"quarkus.otel.resource.attributes", "quarkus.opentelemetry.tracer.resource-attributes"
See: io.quarkus.opentelemetry.runtime.config.OTelFallbackConfigSourceInterceptor
Fixes quarkusio/quarkus#32064 Note that I haven't handled Yaml config files as it doesn't work very well when adding a new prefix (it does not separate configuration properties on dots and thus doesn't work properly with Quarkus).
|
@brunobat I removed the sampler ones and added the ones you mentioned. Let me know if that works for you. |
Fixes quarkusio/quarkus#32064
Note that I haven't handled Yaml config files as it doesn't work very well when adding a new prefix (it does not separate configuration properties on dots and thus doesn't work properly with Quarkus).
/cc @rsvoboda
@brunobat could you check it makes sense?