Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Renarde with new migration script #99

Draft
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 11, 2023

@FroMage here is the result of the new migration script.

Could you make sure it addresses the concerns you expressed?

  • It transforms the documentation
  • It transforms the codestarts (but you will have to update the snapshots by yourself if you have codestarts tests - IIRC, it prompts you to use something like -Dsnap to refresh them automatically)

I wasn't able to build it as, apparently, there are some changes around multipart handling but I think it has nothing to do with the migration process itself.

Obviously, don't merge this PR :).

@gsmet gsmet requested a review from FroMage February 11, 2023 13:04
@FroMage
Copy link
Contributor

FroMage commented Feb 13, 2023

I wasn't able to build it as, apparently, there are some changes around multipart handling but I think it has nothing to do with the migration process itself.

Ah, I wondered if this should be handled by the migration tool or not, it's RR who moved classes around for 3.x, do you think it should? Or is this only for jakarta?

As for the rest, LGTM :)

@gsmet
Copy link
Member Author

gsmet commented Feb 14, 2023

It could be handled if it's just classes being moved around. Can you list me the transformations that should be made with old class -> new class? I'll have a a look.

@FroMage
Copy link
Contributor

FroMage commented Feb 14, 2023

From https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#resteasy-reactive:

  • org.jboss.resteasy.reactive.server.core.multipart.MultipartFormDataOutputorg.jboss.resteasy.reactive.server.multipart.MultipartFormDataOutput
  • org.jboss.resteasy.reactive.server.core.multipart.PartItemorg.jboss.resteasy.reactive.server.multipart.PartItem
  • org.jboss.resteasy.reactive.server.core.multipart.FormData.FormValueorg.jboss.resteasy.reactive.server.multipart.FormValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants