feat(errorcode): Undeprecate ACCOUNT_IN_USE and improve comments

quan-to · Mar 20, 2020 · ee561c0 · ee561c0
1 parent 52ced06
commit ee561c0
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 20 deletions.
diff --git a/dist/models/ErrorCodes.js b/dist/models/ErrorCodes.js
diff --git a/dist/models/ErrorCodes.js.map b/dist/models/ErrorCodes.js.map
diff --git a/dist/models/ErrorObject.js b/dist/models/ErrorObject.js
diff --git a/dist/models/ErrorObject.js.map b/dist/models/ErrorObject.js.map
diff --git a/dist/qlog/index.d.ts b/dist/qlog/index.d.ts
@@ -22,16 +22,23 @@ declare class QLog {
     slash(): void;
     _enableLog(logName: string): void;
     _disableLog(logName: string): void;
-    headPadding: any;
+    set headPadding(value: number | null);
+    get headPadding(): number | null;
     enableLogs(...args: string[]): void;
     disableLogs(...args: string[]): void;
     scope(...name: string[]): QLog;
-    showDateTime: boolean;
-    showScope: boolean;
-    showBadge: boolean;
-    showLabel: boolean;
-    showErrorCodeErrorData: boolean;
-    showFilename: boolean;
+    set showDateTime(value: boolean);
+    get showDateTime(): boolean;
+    set showScope(value: boolean);
+    get showScope(): boolean;
+    set showBadge(value: boolean);
+    get showBadge(): boolean;
+    set showLabel(value: boolean);
+    get showLabel(): boolean;
+    set showErrorCodeErrorData(value: boolean);
+    get showErrorCodeErrorData(): boolean;
+    set showFilename(value: boolean);
+    get showFilename(): boolean;
 }
 declare const _default: QLog;
 export default _default;
diff --git a/src/models/ErrorCodes.ts b/src/models/ErrorCodes.ts
@@ -6,7 +6,8 @@ const ErrorCodes: { [id: string]: string } = {
   // region Public Use
   InternalServerError: 'INTERNAL_SERVER_ERROR',
   NotFound: 'NOT_FOUND',
-  // deprecated
+
+  // deprecated in favor of ErrorCode: INVALID_LOGIN_INFORMATION -> ErrorField: email -> Message: Email Already in Use
   EmailAlreadyInUse: 'EMAIL_ALREADY_IN_USE',
   NoDataAvailable: 'NO_DATA_AVAILABLE',
   InvalidLoginInformation: 'INVALID_LOGIN_INFORMATION',
@@ -19,18 +20,18 @@ const ErrorCodes: { [id: string]: string } = {
   AlreadyPaid: 'ALREADY_PAID',
   PaymentError: 'PAYMENT_ERROR',
   InsufficientFunds: 'INSUFFICIENT_FUNDS',
-  // deprecated
+  // deprecated in favor of ErrorCode: SYSTEM_UNAVAILABLE -> ErrorField: bank
   BankingSystemOffline: 'BANKING_SYSTEM_OFFLINE',
   OutdatedAPI: 'OUTDATED_API',
-  // deprecated
+  // deprecated in favor of ErrorCode: NOT_SUPPORTED -> ErrorField: bank
   BankNotSupported: 'BANK_NOT_SUPPORTED',
   // deprecated
   VaultSystemOffline: 'VAULT_SYSTEM_OFFLINE',
   ServerIsBusy: 'SERVER_IS_BUSY',
   Revoked: 'REVOKED',
   AlreadySigned: 'ALREADY_SIGNED',
   Rejected: 'REJECTED',
-  // deprecated
+  // deprecated in favor of ErrorCode: NOT_SUPPORTED -> ErrorField: operation
   OperationNotSupported: 'OPERATION_NOT_SUPPORTED',
   GraphQLError: 'GRAPHQL_ERROR',
   OperationLimitExceeded: 'OPERATION_LIMIT_EXCEEDED',
@@ -40,7 +41,6 @@ const ErrorCodes: { [id: string]: string } = {
   NotImplemented: 'NOT_IMPLEMENTED',
   MaxOTPTriesExceeded: 'MAX_OTP_TRIES_EXCEEDED',
 
-  // deprecated
   AccountInUse: 'ACCOUNT_IN_USE',
   AccountLocked: 'ACCOUNT_LOCKED',
   NotSupported: 'NOT_SUPPORTED',