Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) qip-0001: refactor to markdown #12

Merged
merged 3 commits into from
Nov 29, 2023
Merged

(fix) qip-0001: refactor to markdown #12

merged 3 commits into from
Nov 29, 2023

Conversation

alanorwick
Copy link
Contributor

No description provided.

wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0001.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy reviewed Nov 27, 2023
View reviewed changes
qip-0003.md Outdated Show resolved Hide resolved
wizeguyy
wizeguyy requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go to markdown, we should rewrite the build scripts too. i.e. the TOC generator and link checker are definitely broken now.

also, please use git mv for the README and qip-0004, so that I can review their diffs

@alanorwick alanorwick force-pushed the markdown branch 8 times, most recently from 90f4656 to 7ad167f Compare November 28, 2023 17:49
@alanorwick alanorwick requested a review from wizeguyy November 28, 2023 17:49
@alanorwick
Copy link
Contributor Author

If we go to markdown, we should rewrite the build scripts too. i.e. the TOC generator and link checker are definitely broken now.

also, please use git mv for the README and qip-0004, so that I can review their diffs

Decision was to remove the scripts for the time being

wizeguyy
wizeguyy requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword your commits. The first two commits touch much more than qip-0001. The last commit doesn't touch qip-0001 at all.

Also, there's still several unexplained heading level changes. Is this intentional?

qip-0001.md Outdated Show resolved Hide resolved
@alanorwick alanorwick requested a review from wizeguyy November 28, 2023 20:25
@alanorwick alanorwick merged commit 2c1c4d8 into quai-network:master Nov 29, 2023
@alanorwick alanorwick deleted the markdown branch November 29, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gameofpointers gameofpointers gameofpointers approved these changes

@wizeguyy wizeguyy wizeguyy approved these changes

@mechanikalk mechanikalk Awaiting requested review from mechanikalk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanorwick @wizeguyy @gameofpointers