depthWrite as part of schema #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefull for children that may have to much spill when combined with depthWrite:true
|
I extended the initial commit with a new one that fix the limitations encountered in self occlusion. previously : now : With this fix, and some proper scene management and splatting cleaning (removing ghost blobs), you can get an almost perfect occlusion ! to be pushed as part of #20 |
encapsulating the fetch into an autoretry loop spaced by 1s delay Parsing logic has been moved into new parseData function
|
Thanks @arthurmougin for your work on this! @quadjr I can confirm this works as expected and we have done our best to ensure that the default settings are not affected, so that a user has to explicitly choose to enable these sorting options. |
|
@quadjr have you had a chance to review here? Excited to work with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #20, I noticed that switching depthWrite from false to true would improve drastically Occlusion issues at the cost of some transparency spillage.
So it could be interesting to have it as an option when those spills are acceptable.
Example with depthWrite: false
Example with depthWrite: true
Please understand that it is not a proper #20 fix, just a workaround while a proper implementation is in progress