Merge pull request #11 from qtumproject/earlz/optimize-deleteaddresses

Change std::vector to std::set for deleteAddresses
qtumproject · Jun 25, 2017 · 1a8e6a4 · 1a8e6a4
2 parents 9393009 + 6f05e8c
commit 1a8e6a4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/libethcore/SealEngine.h b/libethcore/SealEngine.h
@@ -84,7 +84,7 @@ class SealEngineFace
 	virtual bigint costOfPrecompiled(Address const& _a, bytesConstRef _in, u256 const&) const { return m_params.precompiled.at(_a).cost(_in); }
 	virtual std::pair<bool, bytes> executePrecompiled(Address const& _a, bytesConstRef _in, u256 const&) const { return m_params.precompiled.at(_a).execute(_in); }
 
-	mutable std::vector<Address> deleteAddresses; // qtum
+	mutable std::set<Address> deleteAddresses; // qtum
 
 protected:
 	virtual bool onOptionChanging(std::string const&, bytes const&) { return true; }

diff --git a/libethereum/Executive.cpp b/libethereum/Executive.cpp
@@ -307,7 +307,7 @@ bool Executive::call(CallParameters const& _p, u256 const& _gasPrice, Address co
 
 	//////////////////////////////////////////////// // qtum
 	if(!m_s.addressInUse(_p.receiveAddress))
-		m_sealEngine.deleteAddresses.push_back(_p.receiveAddress);
+		m_sealEngine.deleteAddresses.insert(_p.receiveAddress);
 	////////////////////////////////////////////////
 
 	// Transfer ether.

diff --git a/libethereum/ExtVM.cpp b/libethereum/ExtVM.cpp
@@ -136,7 +136,7 @@ void ExtVM::suicide(Address _a)
 	// m_s.addBalance(_a, m_s.balance(myAddress));
 	// m_s.subBalance(myAddress, m_s.balance(myAddress));
 	if(!m_s.addressInUse(_a)){
-		m_sealEngine.deleteAddresses.push_back(_a);
+		m_sealEngine.deleteAddresses.insert(_a);
 	}
 	m_s.transferBalance(myAddress, _a, m_s.balance(myAddress));
 	ExtVMFace::suicide(_a);