Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cw/readme scroll #657

Merged
merged 8 commits into from
Dec 21, 2021
Merged

Cw/readme scroll #657

merged 8 commits into from
Dec 21, 2021

Conversation

chriswhong
Copy link
Contributor

@chriswhong chriswhong commented Dec 21, 2021

Closes #651

  • Fix: CSS tweaks to readme editor so it will be 100% height with a scrolling textarea

Closes #646

  • Fixes layout bug in CommitInfoHeader when commit title is long
  • Requires user to add a commit message when editing an existing dataset
  • Adds editing icons to dataset preview panes if user can edit dataset
  • Fixes a layout bug in history view (edit dot showing when edit button is missing)
  • Optimizes space in collection list, so name column has a bit more width

image

  • After manual edits to a component tab, navigates to history with the same tab selected

@chriswhong chriswhong requested a review from ramfox December 21, 2021 21:27
Copy link
Member

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The small commits made this simple to review.

woo!

@chriswhong chriswhong merged commit fd91baf into master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Punchlist Cannot scroll in readme editor
2 participants