Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-2449 Update Aggregate Repository to v23.1 #12

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

SamBucaMatthews
Copy link
Member

PC-2449 Update Aggregate Repository to v23.1

Copy link

Pull Request Review Checklist:

  • Variable have been given sensible, meaningful names.
  • LINQ to SQL datacontexts must always be initialised with an explicit connection string drawn from a config file.
  • Code is DRY (Dont Repeat Yourself). (But make sure where this is applied, the two things are actually the same!)
  • No values have been hard-coded where they should be drawn from a config file.
  • Comments are present where appropriate, and provide useful information not just stating what the code is obviously doing.
  • Error handling is performed appropriately where things might fail.
  • Logging is present, useful, and uses log levels appropriately.
  • If new app config values are referenced in the code, a placeholder must be committed in the config file.
  • If new app config values are referenced in the code, they must be added to octopus before approving this PR.
  • For projects with snapshotting, any new fields added to viewmodels must declare datamembers appropriately.
  • For projects with snapshotting, any new viewmodels should be added to the snapshot load/save code in the bootstrapper.

Copy link

@JoshPattie JoshPattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you've spun up the tests?

@SamBucaMatthews
Copy link
Member Author

LGTM assuming you've spun up the tests?

Of course!

@rcknight rcknight merged commit 4c6df25 into master Nov 21, 2023
2 checks passed
@rcknight rcknight deleted the PC-2449-update-aggregate-repository-to-23.1 branch November 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants