Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop node v16 #810

Merged
merged 2 commits into from
Nov 14, 2023
Merged

feat: drop node v16 #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c47a2
feat: drop support for Node 16
vscav Nov 14, 2023
9d5c72d
doc: add Node compatibility information
vscav Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Run Lint
run: pnpm lint
Expand All @@ -46,7 +46,7 @@ jobs:
- name: Install pnpm
uses: wyvox/action-setup-pnpm@v3
with:
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Update TS version on addon package
run: pnpm add -D ${{ matrix.typescript-scenario }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16
node-version: 18.x
node-registry-url: "https://registry.npmjs.org"
- name: Build addon
run: pnpm build
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Test
run: pnpm test:ember
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Test
run: pnpm ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
Expand All @@ -77,7 +77,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--no-lockfile"
- name: Test
run: pnpm test:ember
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ ember install ember-phone-input
- Ember CLI v2.13 or above
- ember-auto-import v2 or above (ember-phone-input@6 is compatible with previous
versions of ember-auto-import)
- Node.js v18 or above
- TypeScript v5.0 or above

## Contributing
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"release-it": "16.2.1"
},
"engines": {
"node": "16.* || >= 18"
"node": ">= 18"
},
"volta": {
"node": "18.18.2"
Expand Down
2 changes: 1 addition & 1 deletion test-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"webpack": "5.89.0"
},
"engines": {
"node": "16.* || >= 18"
"node": ">= 18"
},
"ember": {
"edition": "octane"
Expand Down