Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove double pnpm installation #645

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: remove double pnpm installation #645

merged 1 commit into from
Sep 21, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Jun 5, 2023

This MR removes the double pnpm install: NullVoxPopuli/action-setup-pnpm already calls pnpm install and expose an args input.

@vscav vscav marked this pull request as ready for review June 5, 2023 13:16
@vscav vscav self-assigned this Jun 5, 2023
@vscav vscav added the internal label Jun 5, 2023
@vscav vscav requested a review from anas7asia June 6, 2023 07:09
@m-jovan m-jovan force-pushed the remove-double-pnpm-i branch from 83aece0 to 1b2be82 Compare September 21, 2023 11:09
@m-jovan m-jovan merged commit 17117ad into master Sep 21, 2023
11 checks passed
@m-jovan m-jovan deleted the remove-double-pnpm-i branch September 21, 2023 12:18
@vscav vscav changed the title Remove double pnpm installation fix: remove double pnpm installation Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulet42 poulet42 poulet42 approved these changes

@anas7asia anas7asia Awaiting requested review from anas7asia

Assignees

@vscav vscav

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vscav @poulet42 @m-jovan