Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to add new illustration #457

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

dbendaou
Copy link
Member

@dbendaou dbendaou commented Sep 12, 2022

Description

We've made a request to the brand team to have dedicated illustration for our public repos

See result https://github.com/qonto/ember-phone-input/blob/e4802d683d66b49211a4197a9207d2e9805c26e9/README.md

@mrloop mrloop self-requested a review September 13, 2022 09:11
@mrloop
Copy link
Member

mrloop commented Sep 13, 2022

Looks good to me

@mrloop mrloop merged commit 49ed98a into master Sep 13, 2022
@mrloop mrloop deleted the dbendaou-illustration-1 branch September 13, 2022 09:12
@@ -1,3 +1,5 @@
![ember-phone-input-illustration](https://user-images.githubusercontent.com/15218861/189689656-b468ab1d-d2b7-4145-a9a6-0f4d6e6d240e.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this use a local path name instead of a random URL? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants