add 'allowAutoFormat' option to disable automatic transformation letters -> numbers #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug description: letters transformed to numbers on user input (trying to fit to valid phone number) - this behaviour was pretty confusing and we hadn't any options to turn-off this transformation.
Solution:
With
@allowAutoFormat={{false}}option we can disable transformation, so user input remains unchanged.Default value is
trueChanges
@allowAutoFormat={{false}}. Iffalse- letters not transformed to numbers automatically.Screenshots
Before:
input: +353 7890 test for both cases
Reproduction instructions
→
Checklist
Obvisously, add your option
Do not forget to write inline documentation for your code in addon/components/phone-input
Add a test, probably in tests/integration/components/phone-input-test.js
Add a playground example in tests/dummy/app/pods/docs/components/phone-input/all-options/template