Generic Implementation #88
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to @suhlig's PR by adding an A (for Arguments) parameter, so that the type of actions and guards can be fully type specified.
Also added an "Args" helper type, that preserves the old behavior of using reflect.TypeOf in order to do dynamic typing if desired.
I'm not certain that I fully like this implementation, or that the addition of having typing for the arguments outweighs the relative added complexity of smuggling an "A" around all over the code. On the other hand, for the typical kind of application I've been using stateless for, I often have the same or a very similar argument for all the times I actually need an argument, and nothing at all the rest of the time.