Expose rgb_matrix_update_pwm_buffers to be available in keymaps #24573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing this API enables the examples in the keyboard shutdown/reboot documentation to compile instead of calling `rgb_matrix_driver.flush` directly.
waffle87
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
You're also welcome to remove the existing prototypes that keyboards using this function have:
keyboards/bastardkb/dilemma/dilemma.c
keyboards/bastardkb/charybdis/charybdis.c
keyboards/miiiw/blackio83/rev_0100/rev_0100.c
|
Great suggestion. I'll be able to update the PR this weekend and will remove the extraneous prototypes. |
Now that `rgb_matrix_update_pwm_buffers` is public, there isn't the need for local prototype declarations.
@waffle87, I got around to removing the extraneous local prototype declarations. The PR has been updated. |
|
LGTM, just waiting on another review. |
drashna
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing this API enables the examples in the keyboard shutdown/reboot documentation to compile instead of calling
rgb_matrix_driver.flushdirectly.Types of Changes
Issues Fixed or Closed by This PR
Checklist