-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-volatile memory data repository pattern #24356
Open
tzarc
wants to merge
29
commits into
qmk:develop
Choose a base branch
from
tzarc:data-repository
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,407
−823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
force-pushed
the
data-repository
branch
from
September 2, 2024 23:08
fff8793
to
f78412d
Compare
tzarc
force-pushed
the
data-repository
branch
from
September 3, 2024 02:14
0a1cb2a
to
3574948
Compare
tzarc
changed the title
[WIP] Add non-volatile memory system.
Non-volatile memory data repository pattern
Sep 3, 2024
…can use them too.
tzarc
added
develop-fast-track
Intended to be merged early in the next develop cycle.
breaking_change_2025q1
Targeting breaking changes Q1 2025
and removed
breaking_change_2024q4
Targeting breaking changes Q4 2024
labels
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking_change_2025q1
Targeting breaking changes Q1 2025
core
develop-fast-track
Intended to be merged early in the next develop cycle.
keyboard
keymap
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start of refactoring for non-volatile storage other than EEPROM. Converts
eeconfig
to be a shim, offloading to annvm_eeconfig
equivalent which in turn does the EEPROM writes as of today. Same transformations done forvia
/dynamic_keymap
.New storage mechanisms like the incoming filesystem APIs can then implement
nvm_eeconfig
in its own terms, which may mean one file per concern, as an example. It also paves the way for providing read/write capability for other subsystems, such as combos, key overrides, etc. -- unlikely to be implemented in the EEPROM-backed NVM driver due to a lack of space, but may be available for others.Tested on Satisfaction75 with VIA and its custom configuration stuff, seems to work fine.
TODO:
Types of Changes
Checklist