Issue 135: increase mobile breakpoint for sidebar layouts #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is an improvement! One this I noticed: the width of the overlay narrative col is the full window instead of the narrative col on a demo that is native Is this the bit of 
|
|
Thanks @andrewpbray, have fixed that! Ready to merge if you're otherwise happy with it 😊 |
|
Great - I'm happy! |
andrewpbray
approved these changes
Nov 14, 2024
jimjam-slam
deleted the
jimjam-slam/issue135-Increase-mobile-breakpoint-for-sidebar-layouts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7f4bcf2 makes the structural change here, setting a breakpoint for sidebar layouts one step up the Bootstrap breakpoint ladder (to 768px).
In 6b6832b, I've adjusted the sidebar width in both gallery examples to
minmax(320px, 1fr)(in Auden it wasminmax(400px, 1fr); in Minard it was1fr).I actually think this is a much better default for all users — would you be okay with me changing the CSS custom property default as part of this PR, @andrewpbray?