Skip to content

Commit

Permalink
enhance: Update Knowhere version (milvus-io#38942)
Browse files Browse the repository at this point in the history
Signed-off-by: xianliang.li <[email protected]>
  • Loading branch information
foxspy authored Jan 3, 2025
1 parent 1825ab5 commit af08b5b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion internal/core/thirdparty/knowhere/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# Update KNOWHERE_VERSION for the first occurrence
milvus_add_pkg_config("knowhere")
set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
set( KNOWHERE_VERSION 52c03030 )
set( KNOWHERE_VERSION 1cb3f0e )
set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git")
message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")
message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")
Expand Down
2 changes: 0 additions & 2 deletions tests/go_client/testcases/groupby_search_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ func genGroupByBinaryIndex(metricType entity.MetricType) []index.Index {

func genUnsupportedFloatGroupByIndex() []index.Index {
idxIvfPq := index.NewIvfPQIndex(entity.L2, 128, 16, 8)
idxScann := index.NewSCANNIndex(entity.L2, 16, false)
return []index.Index{
idxIvfPq,
idxScann,
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/python_client/testcases/test_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -10610,7 +10610,7 @@ def test_search_group_by_unsupported_index(self, index):
3. search with group by
verify: the error code and msg
"""
if index in ["HNSW", "IVF_FLAT", "FLAT", "IVF_SQ8", "DISKANN"]:
if index in ["HNSW", "IVF_FLAT", "FLAT", "IVF_SQ8", "DISKANN", "SCANN"]:
pass # Only HNSW and IVF_FLAT are supported
else:
metric = "L2"
Expand Down

0 comments on commit af08b5b

Please sign in to comment.