Used trusted publisher for PyPi #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
added
on hold 🛑
woodsp-ibm
requested review from
stefan-woerner and
adekusar-drl
as code owners
mtreinish
approved these changes
Oct 12, 2023
Comment on lines
+35
to
+37
| run: pip install -U pip setuptools virtualenv wheel | ||
| - name: Build sdist | ||
| run: python3 setup.py sdist bdist_wheel |
There was a problem hiding this comment.
The future proof way to do this is to use:
Suggested change
| run: pip install -U pip setuptools virtualenv wheel | |
| - name: Build sdist | |
| run: python3 setup.py sdist bdist_wheel | |
| run: pip install -U pip setuptools build | |
| - name: Build sdist | |
| run: python3 -m build . |
but for now this works fine.
There was a problem hiding this comment.
Ok, sounds good for the future.
|
This LGTM, you'll need to add a release environment but otherwise this is fine. I left an inline comment, but that's more future facing and we can look at that in a follow up PR as it's not related to using a new publishing mechanism |
Pull Request Test Coverage Report for Build 6564885980
💛 - Coveralls |
adekusar-drl
approved these changes
Oct 12, 2023
oscar-wallis
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows Qiskit/rustworkx#1001 to update the release CI workflow to use PyPI's trusted publisher mechanism.
Details and comments