-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifies code in Data Providers and enhances API reference #335
Conversation
|
@edoaltamura This has been inactive for sometime, did you want to complete this off? You need at least to add |
I can make time to finalize it this coming week! |
Pull Request Test Coverage Report for Build 9479500352Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the comment above but as I said I think its ok. This is something that could always be improved in the future unless you'd like to course.
I updated the method bindings also in a couple of other places where relevant. I like working on the details! 🙂 |
Pull Request Test Coverage Report for Build 9491153560Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for persisting with this. It all seems good to me now.
Summary
Simplifies the usage in data providers and enhances documentation.
Details and comments
BaseDataProvider
: eliminates code repetitions when checking forself._data
and adds more documentation in API reference.RandomDataProvider
,WikipediaDataProvider
,YahooDataProvider
: adds more documentation in API reference.RandomDataProvider
: replaces unnecessary calls to Pandas with more readable Numpy functions.✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.