-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to qiskit_algorithms #291
Switch to qiskit_algorithms #291
Conversation
Pull Request Test Coverage Report for Build 5966254508
💛 - Coveralls |
Optimization switched to |
Co-authored-by: Takashi Imamichi <[email protected]>
I switched the 2 notebooks that used Qiskit Optimization over to using qiskit_algorithms now that Opt has made the change too. I updated the text a little too as well as some of the variable names that were for VQE originally but things were switched over to SamplingVQE when primitive algos were added. It did not change the function just the naming just to remove them simply being called vqe which might, if one wasn't paying attention, cause some confusion - making it sqve for instance I hope allievates that and makes it clearer its SamplingVQE without putting the whole text in which made things a bit verbose - I did for the method in the class though. |
I did a couple of tweaks to links and text that had Qiskit's finance that are not really about qiskit_algorithms, but since I had this PR open and I was reviewing the docs CI built from this PR and spotted them I figured I'd just fix them here. |
I had removed the on-hold label and the [WIP] from the title as it's now complete/ready, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Switches from using qiskit.algorithms, whose use is now deprecated, over to qiskit_algorithms.
Resolves #287
Details and comments
I've listed the items that have been done and tasks under these where changes remain to be done
Added intersphinx to qiskit_algorithms in the docs conf.py, so external refs to that will resolve in the docs
Changed imports and any class refs in docstrings from qiskit.algorithms to qiskit_algorithms. This is in code, tutorials and readme.