[qml] Upgrade QgsRectangle to Q_GADGET & expose QgsLocatorContext's transformContext as property #59568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
locator_context_qml
branch
from
eb27ef2
to
624b5ce
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
force-pushed
the
locator_context_qml
branch
from
624b5ce
to
95e7abd
Compare
nyalldawson
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title says it all, a few more bits exposed to QML environments.
@nyalldawson , failing test adapted to work on both Qt5 and Qt6. Quite interestingly, in Qt6, a QVariant( QgsRectangle ) will have the canConvert() return true instead of false. Doing a qvariant_cast of that variant will also work.
However, both Qt5 and Qt6 return false when calling convert(), so I've upgraded the check to that.