Fix QgsCsException messages (LTR backport) #59543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly showing the "transformed" coordinate result in the exception message, which usually ended up inf, inf after the transform fails. This lead to a useless 'forward transform of (inf, inf)' message in the exception, which was misleading as it looks like we were trying to transform a (inf, inf) point. Now we get the (useful!) actual coordinate we were trying to transform in the exception message. (cherry picked from commit c8d25f6)
…on't need to (cherry picked from commit 276cbec)
The old code mistakenly assumed that proj error codes were all values < 0, which they haven't been since proj 8.0 This meant all QgsCsExceptions were incorrectly including "Error: Fallback transform failed", instead of the actual error message from proj. Now we get eg "Forward transform of (-7603859.000000, -7324441.000000) Error: Invalid coordinate", which makes much more sense (cherry picked from commit 00c7268)
(cherry picked from commit 16de21a)
Eg:
Forward transform (EPSG:4326 to EPSG:3857) of
(-7603859.000000, -7324441.000000) Error: Invalid coordinate
(cherry picked from commit 9b69caf)
(cherry picked from commit b682d36)
(cherry picked from commit 5733e3d)
troopa81
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #59484