Fix freeze on long indexation for snapping on intersections #59519
+45
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
approved these changes
Nov 20, 2024
|
There are (relevant?) issues from test |
Djedouas
force-pushed
the
backport-59259-to-queued_ltr_backports
branch
from
e464455
to
7b3b8d4
Compare
nyalldawson
force-pushed
the
queued_ltr_backports
branch
from
768d167
to
418a7db
Compare
nyalldawson
reviewed
Nov 25, 2024
nyalldawson
force-pushed
the
queued_ltr_backports
branch
from
418a7db
to
077df89
Compare
If snap on intersections is enabled, this specific edge search with the locator was not in relaxed mode, whereas the standard snapping is happening in relaxed mode. As a result, trying to use the snapping during the first indexation was freezing QGIS while the indexation is happening, waiting for it to end. On a layer where the indexation is longer than the timeout (30sec, i.e. a WFS layer as in issue qgis#51179), the locator stops abruptly and resets itself, crashing the indexation and QGIS.
Djedouas
force-pushed
the
backport-59259-to-queued_ltr_backports
branch
from
7b3b8d4
to
c87d85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #59259