Fix running algs with virtual layers #59465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agiudiceandrea Can you take a look at this, If this is the correct approach I can fix other gdal algs as well |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Nov 18, 2024
Comment on lines
+103
to
+108
| source_details = self.getOgrCompatibleSource(self.INPUT, parameters, context, feedback, executing=True) | ||
| # QgsVectorFileWriter defaults to geometry column called geom when exporting virtual, memory and grass layer | ||
| if source_details.layer_name == 'INPUT' and 'INPUT.gpkg' in source_details.connection_string: | ||
| geometry = parameters[self.GEOMETRY] = 'geom' | ||
| else: | ||
| geometry = self.parameterAsString(parameters, self.GEOMETRY, context) |
There was a problem hiding this comment.
Instead of handling this here, I'd rather see:
- An optional "geometry_column_name" field added to the GdalConnectionDetails class. (defaulting to None)
- GdalAlgorithm.getOgrCompatibleSource updated so that the geometry_column_name field is set to "geom" when the source provider is the virtual provider
- All the GDAL algorithms which have a geometry column name updated to ignore this value and use the geometry_column_name from the GdalConnectionDetails object if it's set
How's that sound to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #59364
This allows the following