Fail algorithm when sink cannot be flushed #59241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least reports errors which occur when flushing any buffered features to the user. (Ideally, this would result in a QgsProcessingException being raised so that the algorithm explicitly fails, but we can't do that here as throwing exceptions is prohibited within destructors) Refs qgis#59237
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
rouault
reviewed
Oct 28, 2024
nyalldawson
force-pushed
the
fix_59237
branch
from
d4d302d
to
907aeb6
Compare
|
Ok, this is good to go now |
troopa81
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59237
I don't particularly like this fix, because it requires that EVERY algorithm which uses feature sinks (ie, basically every vector algorithm) should adapt d4d302d manually. Ideas welcome for better approaches...