Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #59092 Remove duplicate equality operator for QgsPointXY #59096

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Backport #59092 Remove duplicate equality operator for QgsPointXY #59096

merged 5 commits into from
Oct 15, 2024

Commits on Oct 15, 2024

  1. Remove duplicate equality operator for QgsPointXY 

    We had two different(!!!!) implementations for equality operator
for QgsPointXY, with different logic (one handled empty points,
the other didn't). This compiled only because one was not marked
as const. So we'd get a DIFFERENT equality check logic depending
on whether or not the first point was const... eeek!

Remove the duplicate one, mark the better one as const
    @nyalldawson @3nids
    nyalldawson authored and 3nids committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4b71aa1 View commit details
    Browse the repository at this point in the history

  2. Fix build 

    I'm not 100% sure if the point == mSnapMatch.point() comparison was
intended be done using QgsPointXY or QgsPoint objects here!

Use QgsPointXY to keep the behavior the same from
before the duplicate QgsPointXY == operator was removed...
    @nyalldawson @3nids
    nyalldawson authored and 3nids committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    74af578 View commit details
    Browse the repository at this point in the history

  3. fix layout

    @3nids
    3nids committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ec3c58d View commit details
    Browse the repository at this point in the history

  4. sipify

    @3nids
    3nids committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ad89192 View commit details
    Browse the repository at this point in the history

  5. const

    @3nids
    3nids committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ef23881 View commit details
    Browse the repository at this point in the history