Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QgsMapLayer::setDataSource don't require layer name, provider #58953

Merged
merged 1 commit into from
Oct 3, 2024
Merged

QgsMapLayer::setDataSource don't require layer name, provider #58953

merged 1 commit into from
Oct 3, 2024

Conversation

nyalldawson
Copy link
Collaborator

Make them optional, and default to current layer name/provider when not specified

@nyalldawson
QgsMapLayer::setDataSource don't require layer name, provider
7bb7802 
Make them optional, and default to current layer name/provider
when not specified
@nyalldawson nyalldawson added the API API improvement only, no visible user interface changes label Oct 3, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Oct 3, 2024
nirvn
nirvn approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instant quality of life improvement.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7bb7802)

@nyalldawson nyalldawson merged commit 94ec0d9 into qgis:master Oct 3, 2024
35 checks passed
@nyalldawson nyalldawson deleted the set_data_source_api branch October 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
API API improvement only, no visible user interface changes
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nyalldawson @nirvn