Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipped render when using geometry generator symbol in layout items #58926

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

nyalldawson
Copy link
Collaborator

Fixes #58909

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 82347f7)

Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not setClipFeaturesToExtent to false for this very symbol, or set an empty extent before rendering instead of adding a new flag?

@nyalldawson
Copy link
Collaborator Author

we not setClipFeaturesToExtent to false for this very symbol,

That's not trivial either, we'd need to set it for all subsymbols for the symbol. The flag is less code 😁

or set an empty extent before rendering instead of adding a new flag?

I thought about that, but I'm concerned that it might cause a new regression if someone has symbology designed around the extent being available.

@nyalldawson nyalldawson merged commit 9df0811 into qgis:master Oct 3, 2024
30 checks passed
@nyalldawson nyalldawson deleted the fix_58909 branch October 3, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout polyline items created with the geometry generator are linked to the first existing layout map
2 participants