Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMYK] Generate a valid PDF/X-4 file #58511

Merged
merged 8 commits into from
Sep 3, 2024
Merged

[CMYK] Generate a valid PDF/X-4 file #58511

merged 8 commits into from
Sep 3, 2024

Conversation

troopa81
Copy link
Contributor

@troopa81 troopa81 commented Aug 28, 2024 •
edited
Loading

Related to qgis/QGIS-Enhancement-Proposals#283

If a colorspace has been set, QGIS would generate a valid PDF/X-4 file (actually not completely valid because of the GDAL issue OSGeo/gdal#10436).

Funded by Bordeaux Métropole

@troopa81
feat(CMYK): Generate a valid PDF/X-4 file
29a1ea8 
When a colorspace has been defined, we generate a valid PDF/X-4 file.
@troopa81 troopa81 added Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks labels Aug 28, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Aug 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7e09c55)

nyalldawson
nyalldawson reviewed Sep 3, 2024
View reviewed changes
src/core/layout/qgslayoutexporter.cpp Outdated Show resolved Hide resolved
src/core/layout/qgslayoutexporter.cpp Outdated Show resolved Hide resolved
src/core/layout/qgslayoutexporter.cpp Outdated Show resolved Hide resolved
src/core/layout/qgslayoutexporter.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson merged commit 0dbca86 into qgis:master Sep 3, 2024
30 checks passed
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 24, 2024
@qgis-bot
Copy link
Collaborator

@troopa81

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
5 participants
@troopa81 @qgis-bot @rouault @nyalldawson @zacharlie