Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto upgrade SVG and text annotations to annotation layer items on project load #58405

Merged
merged 15 commits into from
Aug 25, 2024

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson commented Aug 16, 2024

When loading old projects, any of the old SVG and text annotations will automatically be converted to the newer picture and rectangular text annotation item types.

Remove the actions for creating new SVG and text annotations, and require users to use the corresponding annotation items instead.

Refs qgis/QGIS-Enhancement-Proposals#269

@nyalldawson nyalldawson added the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Aug 16, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit ff96802)

@nyalldawson nyalldawson changed the title Auto upgrade SVG annotations to picture annotation items on project load Auto upgrade SVG and text annotations to annotation layer items on project load Aug 19, 2024
@nyalldawson nyalldawson added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Requires Tests! Waiting on the submitter to add unit tests before eligible for merging labels Aug 19, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis qgis deleted a comment from github-actions bot Aug 20, 2024
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

src/core/annotations/qgsannotationmanager.cpp Outdated Show resolved Hide resolved
src/core/annotations/qgsannotationrectitem.cpp Outdated Show resolved Hide resolved
tests/src/python/test_qgsannotation.py Outdated Show resolved Hide resolved
@nyalldawson nyalldawson merged commit 0467d3f into qgis:master Aug 25, 2024
30 checks passed
@nyalldawson nyalldawson deleted the upgrade_svg_annotatinos branch August 25, 2024 02:34
@qgis-bot
Copy link
Collaborator

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9211
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
@YoannQDQ YoannQDQ mentioned this pull request Nov 24, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants