[ColorWidget] Edit CMYK as percent #58376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Aug 14, 2024
|
Nice work @troopa81 ! |
troopa81
force-pushed
the
ui_cmyk_percent
branch
from
6b97709
to
569e7aa
Compare
troopa81
force-pushed
the
ui_cmyk_percent
branch
from
569e7aa
to
c24b835
Compare
|
I had to add 1b8c949 to make cppcheck happy and avoid the following error message
|
nyalldawson
reviewed
Aug 21, 2024
nyalldawson
reviewed
Aug 21, 2024
troopa81
force-pushed
the
ui_cmyk_percent
branch
from
1b8c949
to
dac3d30
Compare
nyalldawson
approved these changes
Aug 22, 2024
|
unrelated test failure |
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the discussion starting here, this PR proposes to display and edit CMYK values as percentage.
This PR includes #58375
cc @tannenfreund87 @andreasneumann @nyalldawson
Funded by Bordeaux Métropôle