Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc qgis server wfs getFeature fixes when crs is defined as a ogc urn #58355

Merged
merged 6 commits into from
Oct 3, 2024
Merged

misc qgis server wfs getFeature fixes when crs is defined as a ogc urn #58355

merged 6 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. qgswfsgetfeature: Fix outputCrs in startGetFeature if defined as ogc urn 

    The `srsName` used in `QgsWfsGetFeature::startGetFeature` can be
defined with the `urn:ogc:def:crs:EPSG::X` syntax. In that case, the
destination crs is not valid because it is created with the default
`QgsCoordinateReferenceSystem` constructor which does not handle this
syntax.
Therefore, in that case, the requested transformation fails and the
envelope coordinates are always in the input crs (the layer one).

This issue is fixed by using
`QgsCoordinateReferenceSystem::setDestinationCrs` which handles the
ogc urn syntax.

The test suite already covers the `urn:ogc:def:crs:EPSG::X` syntax
case. However, this issue is not detected because the requested output
crs is the same as the input one.
    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    31f6dfa View commit details
    Browse the repository at this point in the history

  2. qgswfsgetfeature: Properly check axis inversion in startGetFeature 

    The axis inversion needs to be checked on the output crs, not the
input one.

The existing test does not detect this issue because the requested
output crs is the same as the input one.
To cover this case, a new test with a output crs different from the
input one is added.
    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9d9ada3 View commit details
    Browse the repository at this point in the history

  3. qgswfsgetfeature: Rename srsName to ouptutSrsName in startGetFeature 

    This makes it easier to understand its usage.
    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6f1d65e View commit details
    Browse the repository at this point in the history

  4. test_qgsserver_wfs: Add some post tests with version 1.1.0

    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    817b0bf View commit details
    Browse the repository at this point in the history

  5. qgswfsgetfeature: Properly handle ogc urns in post requests 

    There are 2 different parameters to check to define the output crs:
- the request parameter (`SRSNAME` from the request)
- the query crs parameter

For a `GET` request, if `SRSNAME` is set, both parameters are set and
equal.
For a `POST` request, only the query parameter is set if defined.

In `writeGetFeature()`, the `outputCrs` correctly takes into account
the query parameter. However, this is not the case for the output srs
name (`srsName`) which only takes into account the query CRS as an
auth id.
Therefore, the output srsName will always be defined as an authid
even if the parameter is an ogc urn.

This issue is fixed by first computing the output srs
name (`outputSrsName`) by taking
into account the query and the query parameters. Then, this name is
used to compute `outputCrs`.
    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3566f8f View commit details
    Browse the repository at this point in the history

  6. qgswfsgetfeature: Use createFromUserInput everywhere for crs

    @ptitjano
    ptitjano committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c492df9 View commit details
    Browse the repository at this point in the history