-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duplicate functionality to Browser connection items #58342
Add duplicate functionality to Browser connection items #58342
Conversation
Vector Tile items in Browser
cf9166f
to
7ed2df5
Compare
7ae9cae
to
e765ddb
Compare
QgsHanaSettings hanaSettings( connectionName, true ); | ||
QgsHanaSettings newHanaSettings( newConnectionName ); | ||
|
||
newHanaSettings.setConnectionType( hanaSettings.connectionType() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These copy settings blocks like quite fragile -- i can easily picture them getting skipped when additional connection properties are added in future. Could they instead be moved to eg QgsHanaSettings so that they're in a closer place to where new settings will be added? (The same applies to the other db types)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As other db types do not have separate class to handle settings I have added method to connection classes.
94a5d8a
to
b9b164e
Compare
@alexbruy A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@alexbruy |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Description
Add "Duplicate connection" action to the context menu of Browser connection items. This allows quickly make a copy of a connection to the same source when only a few details are differ (for example, different PostGIS database on the same server)
Funded by NaturalGIS.