Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Georeferencer preview point fixes #57984

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Georeferencer preview point fixes #57984

merged 4 commits into from
Oct 2, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Jul 4, 2024

Description

  • Preview points cannot be added before a layer is loaded
  • Preview points do not display a point tip
  • Preview points are correctly displayed when zooming/panning the canvases
  • Last clicked preview point is actually used if georef canvas is clicked again while coords dialog is open

Fixes #44986
Fixes #44987
Fixes #44988

Also fixes old unreported regression: residual bars are now updated while moving GCPs

@uclaros uclaros added Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_34 backport release-3_38 labels Jul 4, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 62551be)

roya0045
roya0045 reviewed Jul 4, 2024
View reviewed changes
src/app/georeferencer/qgsgeorefdatapoint.cpp
@@ -92,13 +92,18 @@ void QgsGeorefDataPoint::setEnabled( bool enabled )

void QgsGeorefDataPoint::setId( int id )
{
const bool noLongerTemporary = mId < 0 && id >= 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name doesn't seem optimal, maybe "isValid" or "isPermanent"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to change the color if this call changes the point form a temporary ( < 0 ) to a permanent, hence the noLonger in the name

@uclaros uclaros mentioned this pull request Jul 9, 2024
Closed
2 tasks
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 19, 2024
@qgis qgis deleted a comment from github-actions bot Jul 19, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 19, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 3, 2024
@qgis qgis deleted a comment from github-actions bot Aug 3, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 3, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 18, 2024
@github-actions github-actions bot closed this Aug 25, 2024
@uclaros uclaros reopened this Aug 26, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 26, 2024
@qgis qgis deleted a comment from github-actions bot Aug 26, 2024
@qgis qgis deleted a comment from github-actions bot Aug 26, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 10, 2024
@nyalldawson nyalldawson added Freeze Exempt Feature Freeze exemption granted and removed backport release-3_38 labels Sep 13, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 14, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 28, 2024
@qgis qgis deleted a comment from github-actions bot Oct 1, 2024
@qgis qgis deleted a comment from github-actions bot Oct 1, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 1, 2024
@nyalldawson nyalldawson closed this Oct 2, 2024
@nyalldawson nyalldawson reopened this Oct 2, 2024
@nyalldawson nyalldawson merged commit fae8e82 into qgis:master Oct 2, 2024
92 of 94 checks passed
@qgis-bot qgis-bot mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roya0045 roya0045 roya0045 left review comments

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter! Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Milestone
3.40.0
3 participants
@uclaros @nyalldawson @roya0045