fix(firewall): deduplicate VPN address accept rule for multiple defau…

…lt routes with the same network interface
qdm12 · Oct 6, 2024 · 99e9bc8 · 99e9bc8
1 parent 9ef14ee
commit 99e9bc8
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/internal/firewall/enable.go b/internal/firewall/enable.go
@@ -157,7 +157,13 @@ func (c *Config) allowVPNIP(ctx context.Context) (err error) {
 	}
 
 	const remove = false
+	interfacesSeen := make(map[string]struct{}, len(c.defaultRoutes))
 	for _, defaultRoute := range c.defaultRoutes {
+		_, seen := interfacesSeen[defaultRoute.NetInterface]
+		if seen {
+			continue
+		}
+		interfacesSeen[defaultRoute.NetInterface] = struct{}{}
 		err = c.acceptOutputTrafficToVPN(ctx, defaultRoute.NetInterface, c.vpnConnection, remove)
 		if err != nil {
 			return fmt.Errorf("accepting output traffic through VPN: %w", err)